7x/remove response interface #3670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
force-pushed
the
7x/remove-response-interface
branch
from
37e37da to
7906ff2
Compare
… only being allowed if generic and covariant
|
Reviewed with the team, using my admin powers to merge unreviewed. |
Mpdreamz
added a commit
that referenced
this pull request
Apr 17, 2019
* remove CatResponse * progress commit * things compile again * found more cases * fixed compilation * fix unit tests * DoRequestAsync no longer needs to transform task to interface result * Simplified SuggestDictionary serializer by doing a straight cast * wrote codestandard test to assert new rule around response interfaces only being allowed if generic and covariant (cherry picked from commit 12bf3d8)
|
ported to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Calls now return concrete response implementations.
DoRequestAsync no longer needs to do perform tricks to go from
Task<Response>toTask<IResponse>.Interfaces are kept for responses where they benefit from covariance.
This change now also makes
ISearchRequest<T>completely covariant 🎉